jlcpcb: include board name in gerbers.zip instead of just "gerbers.zip" #493
Conversation
|
Hi, sorry for the long delay in reviewing. The original idea for However, as I learned myself, this makes your life more complicated when ordering multiple PCBs from JLC. So I would like to change this. However, I am aware of several usages out there that rely on the naming, so changing this would be a breaking change. Therefore, I would would like to include in a new major release that is planned after an upcoming minor release that adds v7 support. |
yaqwsx
force-pushed
the
master
branch
3 times, most recently
from
8e0fcb8
to
5445c99
Compare
|
Would it not make more sense to change this so that when a flag is present (e.g. |
yaqwsx
force-pushed
the
master
branch
2 times, most recently
from
63883b3
to
e0c897b
Compare
Output of "fab jlcpcb" is named "gerbers.zip" which makes it somewhat difficult when uploading multiple boards to JLC cart.
This changes the default name (unless
--nametemplateis specified) to<board_name>-gerbers.zip.